Re: [RFC] ASLA design, depth of code review and lack thereof

From: viro
Date: Fri Jun 04 2004 - 18:32:41 EST


On Sat, Jun 05, 2004 at 12:08:19AM +0100, viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx wrote:
> Ladies and gentlemen, may I politely ask what description would fit somebody
> who have made the following
>
> case SNDRV_PCM_FORMAT_FLOAT_BE:
> {
> union {
> float f;
> u_int32_t i;
> } u;
> u.f = 0.0;
> #ifdef SNDRV_LITTLE_ENDIAN
> return bswap_32(u.i);
> #else
> return u.i;
> #endif
> }
> and quite a few similar, er, wonders an ioctl?

... immediately followed by a self-LART - it's still an ugly code, all
right, but that's not an ioctl.

My apologies to everyone.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/