Re: [RFC] ASLA design, depth of code review and lack thereof

[Takashi Iwai]

At Mon, 07 Jun 2004 10:05:41 -0400,
Jeff Garzik wrote:
> 
> Takashi Iwai wrote:
> > They're nice but they don't provide "cast checking", no?
> > The main purpose of the magic_* stuffs in ALSA is to check the cast of
> > the void pointer back to the original data type, which the compiler
> > can't check.
> 
> Sure -- and that magic cast stuff is horribly bloated, and not needed in 
> good code.

A good code needs never debugging stuffs :)

I agree that the current ALSA's magic stuff is much bigger than
needed, though.

> No other code in Linux does this -- therefore it should be removed.

Hmm?  The magic check itself is found in many linux driver codes...


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/