Re: [PATCH] Fix apm suspend with cs4231 based sound cards

[Takashi Iwai]

At Tue, 8 Jun 2004 03:39:52 +1200 (NZST),
Keith Duthie wrote:
> 
> The following patch (effectively a reversion of a change between alsa
> 0.9.4 and 0.9.5) fixes a problem whereby an APM suspend causes the
> program which is using the PCM device to enter the uninterruptible sleep
> state on resume and thus causes the sound device to be unusable.
> 
> --- linux-2.6.5/sound/isa/cs423x/cs4231_lib.c~	Tue Jun  8 03:24:49 2004
> +++ linux-2.6.5/sound/isa/cs423x/cs4231_lib.c	Tue Jun  8 03:24:52 2004
> @@ -1402,7 +1402,7 @@
>  	switch (rqst) {
>  	case PM_SUSPEND:
>  		if (chip->suspend) {
> -			snd_pcm_suspend_all(chip->pcm);
> +			//	snd_pcm_suspend_all(chip->pcm);
>  			(*chip->suspend)(chip);
>  		}
>  		break;

Could you check whether the recent kernel works without this patch?
There was a mutex deadlock in the suspend code, and I guess it hit
you...


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/