Re: Patch: 2.6.7/fs/dnotify.c - make dn_lock a regular spinlock

From: Stephen Rothwell
Date: Thu Jun 17 2004 - 10:28:07 EST


Hi Adam,

On Thu, 17 Jun 2004 16:38:26 -0700 "Adam J. Richter" <adam@xxxxxxxxxxxxx> wrote:
>
> In linux-2.6.7/fs/dnotify.c, the local varible dn_lock is
> declared as rw_lock_t, but the lock is only taken exclusively.
> So, let's "document" this fact, save a few bytes and save a few
> cycles by changing it to spinlock_t.

Fine by me, but other opinions are always welcome.

> If this patch looks acceptable to you, could you please
> tell the appropriate person to integrate it or advise me what to
> do if you want me to proceed some other way? I don't know if you
> submit your patches directly to Linus or through someone else,
> like Al Viro.

Well, Al was the last to modify the dnotify code, if memory serves.
Getting his OK is always a good idea for this sort of thing. Otherwise,
fine my me.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature