Re: [PATCH 2.6.7] Parallel port detection via ACPI

From: Dino Klein
Date: Sun Jun 27 2004 - 21:24:56 EST


Hey,
I have one question about using acpi_register_gsi() - this is an ia64 only thing, right?
Thing is, that I remember an exchange on the acpi mailing list mentioning that there is no legacy hardware on ia64 systems; wouldn't that also include the parallel port?




From: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
To: Dino Klein <dinoklein@xxxxxxxxxxx>
Subject: Re: [PATCH 2.6.7] Parallel port detection via ACPI
Date: Tue, 22 Jun 2004 17:42:36 -0600

Nice start at this! As you note, it needs a little work. Here are
a couple things I noticed:

- the ACPI stuff should be under #ifdef CONFIG_ACPI
- the IRQ should be fed through acpi_register_gsi() (a new
interface that showed up in BK a few days ago)
- there are IRQ and extended IRQ structures -- maybe
should be extended to handle both?
- seems like it'd be nice to arrange it so we look in
ACPI first, then fall back to previous detection if
that fails (probably with a boot-time option to disable
the ACPI detection in case the firmware is buggy)

Again, good work! I'm glad to see us starting to take advantage
of this stuff.

Bjorn

_________________________________________________________________
MSN Messenger: instale grátis e converse com seus amigos. http://messenger.msn.com.br

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/