Re: [PATCH] intrinsic automount and mountpoint degradation support

[Andrew Morton]

David Howells <dhowells@xxxxxxxxxx> wrote:
>
> Here's a patch that I worked out with Al Viro that adds support for a
>  filesystem (such as kAFS) to perform automounting intrinsically without the
>  need for a userspace daemon. It also adds support for such mountpoints to be
>  degraded at the filesystem's behest until they've been untouched long enough
>  that they'll be removed.

Please don't try to add uncommented code to the kernel.

How does this work?

Why is autofs unsuitable?

Apart from documenting the major functions and data structures, comments
are also needed which describe the interpretation of ->mnt_count.  This:

+		if (atomic_read(&mnt->mnt_count) == 2) {

is otherwise incomprehensible.

Apart from making the code maintainable, tasteful commentary and covering
documentation makes the patch review process much more fruitful.  Please
have a think about that, and resend?

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/