Re: PATCH: (as339) Interpret down_trylock() result code correctly in usb.c

[Greg KH]

On Wed, Jul 07, 2004 at 02:54:16PM -0700, Greg KH wrote:
> On Tue, Jul 06, 2004 at 12:11:19PM -0400, Alan Stern wrote:
> > Greg:
> > 
> > As Andrew Morton has already spotted, I messed up the interpretation of
> > the result codes from various _trylock() routines.  I didn't notice that
> > down_trylock() and down_read_trylock() use opposite conventions for
> > indicating success!  This patch fixes the incorrect interpretation of
> > down_trylock().  That error may well be responsible for some of the
> > problems cropping up recently with OHCI controllers.  Please apply.
> 
> Applied.
> 
> But even with this patch, and Andrew's, I have a hang at boot with my
> USB mouse plugged in (uhci system).

If I remove the mouse, and then boot, it works just fine.  I can then
insert it and the drivers are loaded just fine too.

Looks like a race on accessing usbfs and loading a driver at the same
time, as the "cold-boot" code scans usbfs to determine what driver to
load.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/