Re: [PATCH] fix airo oops-on-removal

From: Christoph Hellwig
Date: Thu Jul 08 2004 - 16:35:36 EST


On Thu, Jul 08, 2004 at 05:31:51PM -0400, Bill Nottingham wrote:
> airo creates /proc/driver/aironet/<device name> on device activation.
> However, the device can be renamed - then on teardown
> it tries to remove the wrong directory. The removal of
> /proc/driver/aironet then runs afoul of the BUG_ON() in remove_proc_entry.
>
> This fixes it by keeping a copy of the name of the directory
> it created.
>
> (It doesn't actually solve the problem of the stats directory
> still being /proc/driver/aironet/eth0 when you rename the device
> to, say, 'joe'. But that patch would be a little less trivial.)

Still sounds like a rather broken behaviour. We should probably
nuke that whole procfs interface thingy instead.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/