Re: [PATCH] - Eliminate machvec calls to null functions

[David Mosberger]

>>>>> On Wed, 7 Jul 2004 15:17:16 -0500, Jack Steiner <steiner@xxxxxxx> said:

  Jack> Here is a patch to eliminate calls to null platform vectors for
  Jack> non-GENERIC kernels.

  Jack> If this looks ok, then I'll update the tlb_migrate patch & resubmit
  Jack> it. (Apply this machvec patch first...)

I was about to check this in when it occurred to me that it should be
possible to simply define the no-ops as "static inline".  If you take
the address of these functions, the compiler will instantiate the
function automatically, so this ought to work both for GENERIC and
non-GENERIC kernels.  The only downside is that for GENERIC, each
machvec definition will get its own definition of the
no-op-function(s), but that seems like an acceptable cost to me.

I tried the patch below both for zx1 and GENERIC and it does seem to
work as expected.  If nobody has a problem with the patch, I'll go
ahead and check it in.

	--david

===== arch/ia64/kernel/machvec.c 1.8 vs edited =====
--- 1.8/arch/ia64/kernel/machvec.c	Fri May 21 14:01:23 2004
+++ edited/arch/ia64/kernel/machvec.c	Thu Jul  8 15:34:20 2004
@@ -44,12 +44,6 @@
 #endif /* CONFIG_IA64_GENERIC */
 
 void
-machvec_noop (void)
-{
-}
-EXPORT_SYMBOL(machvec_noop);
-
-void
 machvec_setup (char **arg)
 {
 }
===== include/asm-ia64/machvec.h 1.23 vs edited =====
--- 1.23/include/asm-ia64/machvec.h	Thu Mar 25 11:54:44 2004
+++ edited/include/asm-ia64/machvec.h	Thu Jul  8 15:34:06 2004
@@ -69,7 +69,11 @@
 typedef unsigned int ia64_mv_readl_relaxed_t (void *);
 typedef unsigned long ia64_mv_readq_relaxed_t (void *);
 
-extern void machvec_noop (void);
+static inline void
+machvec_noop (void)
+{
+}
+
 extern void machvec_setup (char **);
 extern void machvec_timer_interrupt (int, void *, struct pt_regs *);
 extern void machvec_dma_sync_single (struct device *, dma_addr_t, size_t, int);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/