Re: [LTP] Re: Recent changes in LTP test results

[Bryce Harrington]

Hi David,

Thanks, I tried this patch out, and it does fix the accept01 error.  :-)

    http://khack.osdl.org/stp/294783/

Do you have ideas on the other failures encountered?

Bryce

On Wed, 7 Jul 2004, David S. Miller wrote:
> On Wed, 7 Jul 2004 13:48:52 -0700 (PDT)
> Bryce Harrington <bryce@xxxxxxxx> wrote:
>
> > I have retested with ltp-full-20040603.  This version of LTP hangs on
> > our system but fortunately completes most of the tests before doing so.
> > It indicates that it still encounters the same errors, e.g.:
>
> It hangs (actually, it OOPS's) on accept01, which is fixed in the current
> BK sources via this patch:
>
> # This is a BitKeeper generated diff -Nru style patch.
> #
> # ChangeSet
> #   2004/07/06 22:02:06-07:00 davem@xxxxxxxxxxxxxxxxxx
> #   [IPV4]: Set UDP accept back to sock_no_accept.
> #
> #   Setting it to inet_accept causes UDP accept attempts
> #   to OOPS.  In particular, accept01 from LTP tries this.
> #
> #   Signed-off-by: David S. Miller <davem@xxxxxxxxxx>
> #
> # net/ipv4/af_inet.c
> #   2004/07/06 22:01:31-07:00 davem@xxxxxxxxxxxxxxxxxx +1 -1
> #   [IPV4]: Set UDP accept back to sock_no_accept.
> #
> #   Setting it to inet_accept causes UDP accept attempts
> #   to OOPS.  In particular, accept01 from LTP tries this.
> #
> #   Signed-off-by: David S. Miller <davem@xxxxxxxxxx>
> #
> diff -Nru a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c
> --- a/net/ipv4/af_inet.c	2004-07-07 14:09:13 -07:00
> +++ b/net/ipv4/af_inet.c	2004-07-07 14:09:13 -07:00
> @@ -823,7 +823,7 @@
>  	.bind =		inet_bind,
>  	.connect =	inet_dgram_connect,
>  	.socketpair =	sock_no_socketpair,
> -	.accept =	inet_accept,
> +	.accept =	sock_no_accept,
>  	.getname =	inet_getname,
>  	.poll =		datagram_poll,
>  	.ioctl =	inet_ioctl,
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/