Re: [Patch]: Fix rivafb's NV_ARCH_, cleanup DEBUG, backlight control on ppc

From: Antonino A. Daplas
Date: Fri Jul 09 2004 - 16:38:24 EST


On Friday 09 July 2004 19:25, Guido Guenther wrote:
> On Mon, Jun 21, 2004 at 10:36:44AM -0500, Benjamin Herrenschmidt wrote:
> > Ok, well, it looks good to me. There is no active maintainer for rivafb
> > so, I suppose if nobody complains of breakage, it should be fine.
>
> Since this isn't in yet. Here's another version that:
> - fixes the PCI-IDs (needed to get it to work on at least the NV17)
> - cleans up the DEBUG option (similar to the new radeonfb). This also
> makes it easy to replace printk by btext_printf() (on ppc) or similar
> to ease debugging of the fb code when all else fails.
> - adds backlight control for Apple powerbooks
> Patch is against 2.6.7-bk20. Please apply,
> -- Guido

Tried the patch, and works okay for me (NV10 x86). I'm not really too
keen on making debug printing as a kernel config option, but it's a minor point.
This patch should be applied.

Tony


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/