Re: [PATCH] edd (Re: Linux 2.6.8-rc1)

From: Randy.Dunlap
Date: Mon Jul 12 2004 - 00:29:43 EST


On Sun, 11 Jul 2004 23:49:46 -0500 Matt Domsch wrote:

| On Sun, Jul 11, 2004 at 04:00:19PM -0700, Randy.Dunlap wrote:
| > drivers/built-in.o: In function `edd_has_mbr_signature':
| > drivers/built-in.o(.text+0x13b84f): undefined reference to `edd'
| > drivers/built-in.o(.init.text+0xd39c): more undefined references to `edd' follow
| >
| > CONFIG_EDD=y on X86o
| >
| > 'edd' needs to be exported for drivers/firmware/edd.c
|
| I don't think so. It only needs be exported if a module is going to
| use it. Since you're building it in, not as a module, it should be
| fine.
|
| My own 'make defconfig' on a clean BK tree, enabling CONFIG_EDD=y,
| links correctly. Perhaps a make mrproper; make would be in order, as the
| deps stage should have caught it for you...

OK, I don't know how it happened, but not a problem now.

Sorry about that.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/