Problem with __user annotation in drivers/block/ida_ioctl.h

[Toon van der Pas]

Hi,

I'm using the cpqarrayd-2.0 daemon in order to monitor the volumes that
are managed by the cciss driver. After I upgraded the kernel to 2.6.7
(coming from 2.6.0), the compilation of the daemon failed because of the
__user annotation that was added in the file drivers/block/ida_ioctl.h
as part of the sparse fixes.

I did some research (read: googling) and found out that this could
be solved by including /usr/src/linux/include/linux/compiler.h.
To prove this, I inserted #include statements for the compiler.h file in
all source files of the cpqarrayd-2.0 daemon where ida_ioctl.h was included.
With these changes the daemon compiled and ran without problems.

QUESTION: what is the right fix for this?
I think the header file linux/compiler.h needs to be included in
the file drivers/block/ida_ioctl.h.  This way we prevent all user
space tools from breaking.  Am I right?

Regards,
Toon.
-- 
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/