Re: [PATCH] Use NULL instead of integer 0 in security/selinux/

[Andreas Schwab]

Timothy Miller <miller@xxxxxxxxxxxxxx> writes:

> Denis Vlasenko wrote:
>> The question is, whether readers of your code (including compiler)
>> will be able to be sure that there is no error in
>> 	f(a,b,c,d,e,0,f,g,h);
>> statement or not. Better typecheck that 0.
>
> This I agree with, definately.  It's very important to make your code
> readable, and if it's not obvious from context, make it obvious.  Cases
> like the above are one of the reasons I like languages like Verilog where
> you can pass parameters by specifying the parameter name.

If your function needs nine arguments it is not readable by
definition. :-)

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/