Re: [PATCH] 1/1: Device-Mapper: Remove 1024 devices limitation

From: Andrew Morton
Date: Mon Jul 12 2004 - 13:18:15 EST


Kevin Corry <kevcorry@xxxxxxxxxx> wrote:
>
> On Wednesday 07 July 2004 6:10 am, Andrew Morton wrote:
> > Jim Houston <jim.houston@xxxxxxxxxxx> wrote:
> > >
> > > Hi Andrew,
> > >
> > > It's not quite right. If you want to keep a count in the upper bits
> > > you have to mask off that count before checking if the id is beyond the
> > > end of the allocated space.
> >
> > OK, I'll fix that up.
> >
> > But I don't want to keep a count in the upper bits! I want rid of that
> > stuff altogether, completely, all of it. It just keeps on hanging around
> > :(
> >
> > We should remove MAX_ID_* from the kernel altogether.
>
> Just following up on the proposed IDR changes. Based on the patches in the
> latest -mm tree, I'm assuming there is or will be a fix for IDR so it will
> always return NULL when asked to find an id that's not currently allocated.
> Is this correct? If so, I can drop the second "dm-use-idr" patch (from July
> 6, 2004) and keep the one that's currently in -mm.
>

Yes, I'm assuming that the code in Linus's tree at present is acceptable,
and I'll take another look at the idr code post-2.6.8.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/