[PATCH][2.6] fix return codes after i2c_add_driver() in tea6415cand tea6420
From: Michael Hunold
Date: Mon Jul 12 2004 - 14:57:14 EST
Hello Linus, Andrew,
in two of my i2c helper drivers the return value of i2c_add_driver() is
ignored. Thanks to Arthur Othieno for finding these bugs.
The patch is trivial. Please apply.
CU
Michael.
- [V4L] - i2c_add_driver() may actually fail, but both tea6420 and tea6415c driver return 0 regardless
Signed-off-by: Arthur Othieno <a.othieno@xxxxxxxxxx>
Signed-off-by: Michael Hunold <hunold@xxxxxxxxxxx>
--- a/drivers/media/video/tea6420.c 2003-12-18 03:58:49.000000000 +0100
+++ b/drivers/media/video/tea6420.c 2004-06-04 18:14:36.000000000 +0200
@@ -197,13 +197,12 @@ static struct i2c_driver driver = {
.command = tea6420_command,
};
-static int tea6420_init_module(void)
+static int __init tea6420_init_module(void)
{
- i2c_add_driver(&driver);
- return 0;
+ return i2c_add_driver(&driver);
}
-static void tea6420_cleanup_module(void)
+static void __exit tea6420_cleanup_module(void)
{
i2c_del_driver(&driver);
}
--- a/drivers/media/video/tea6415c.c 2003-12-18 03:59:16.000000000 +0100
+++ b/drivers/media/video/tea6415c.c 2004-03-31 20:24:35.000000000 +0200
@@ -217,13 +217,12 @@ static struct i2c_driver driver = {
.command = tea6415c_command,
};
-static int tea6415c_init_module(void)
+static int __init tea6415c_init_module(void)
{
- i2c_add_driver(&driver);
- return 0;
+ return i2c_add_driver(&driver);
}
-static void tea6415c_cleanup_module(void)
+static void __exit tea6415c_cleanup_module(void)
{
i2c_del_driver(&driver);
}