Re: [PATCH] pmac_zilog: initialize port spinlock on all init paths

[Benjamin Herrenschmidt]

On Mon, 2004-07-12 at 19:39, David Eger wrote:
> Dear Ben,
> 
> This patch fixes the Zilog driver so it doesn't freak on my TiBook.

The spinlock should be initialized by the serial core when registering
the ports ... can you find out for me how do you end up with the
port not registered but still trying to use the lock ? The port
do exist on tipb's even if it has no visible connectors (actually
some tipbs have an irda output on port B and port A is available
on the motherboard, I think on the modem connector, though there
is no "adapter" that I know of to get it out).

> ( of course, it still spews diahrea of 'IN from bad port XXXXXXXX'
>   but then, I don't have the hardware.... still, seems weird that OF
>   would report that I do have said hardware :-/ )

The IN from bad port is a different issue, it's probably issued by
another driver trying to tap legacy hardware, either serial.o or
ps/2 kbd, I suppose, check what else of that sort you have in your
 .config

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/