Re: [PATCH] Making i/dhash_entries cmdline work as it use to.

[Dave Hansen]

On Mon, 2004-07-12 at 19:37, Jose R. Santos wrote:
> * Jose R. Santos <jrsantos@xxxxxxxxxxxxxx> [2004-07-12 12:56:05 -0500]:
> > Also, any particular reason why MAX_SYS_HASH_TABLE_ORDER was set to 14?
> > I am already seeing the need to go higher on my 64GB setup and was 
> > wondering if this could be bumped up to 19.
> 
> Actualy, it doesnt look like we need MAX_SYS_HASH_TABLE_ORDER at all so
> I'm resending the patch which now limits the max size of a hash table to
> 1/16 total memory pages.  This would keep people from doing dangerous
> things when using the hash_entries.

Do you worry that you're just expanding the hash table as long as it
gives benefit on your one, single benchmark?  There have to be plenty of
other workloads that could benefit from an extra 1/16th more memory. 
Not every workload is as dcache heavy as SFS.  

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/