Re: [PATCH] 2.6.8-rc1 fix AFS struct_cpy use which break !X86

[Darren Williams]

Yep, that fixed it, we'll wait for the original patch to be merged.

see
http://lkml.org/lkml/2004/7/12/176
for the original thread and patch.

Thanks
Darren

> Ok, what about the following patch ?
> 
> Index: fs/afs/mntpt.c
> ===================================================================
> --- fs/afs/mntpt.c	(revision 1)
> +++ fs/afs/mntpt.c	(working copy)
> @@ -257,7 +257,7 @@
>  	if (IS_ERR(newmnt))
>  		return PTR_ERR(newmnt);
>  
> -	struct_cpy(&newnd, nd);
> +	newnd = *nd;
>  	newnd.dentry = dentry;
>  	err = do_add_mount(newmnt, &newnd, 0, &afs_vfsmounts);
>  
> Index: fs/afs/vlocation.c
> ===================================================================
> --- fs/afs/vlocation.c	(revision 1)
> +++ fs/afs/vlocation.c	(working copy)
> @@ -906,7 +906,7 @@
>  		if (!vlocation->valid ||
>  		    vlocation->vldb.rtime == vldb->rtime
>  		    ) {
> -			struct_cpy(&vlocation->vldb, vldb);
> +			vlocation->vldb = *vldb;
>  			vlocation->valid = 1;
>  			_leave(" = SUCCESS [c->m]");
>  			return CACHEFS_MATCH_SUCCESS;
> @@ -947,7 +947,7 @@
>  
>  	_enter("");
>  
> -	struct_cpy(vldb,&vlocation->vldb);
> +	*vldb = vlocation->vldb;
>  
>  } /* end afs_vlocation_cache_update() */
>  #endif


--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/