Re: 2.6.8-rc1-mm1

[David Howells]

> btw, David, I'm wondering about this loop:
> 
> 	do {
> 		size = bucketsize << log2qty;
> 
> 		table = (void *) alloc_bootmem(size);
> 
> 	} while (!table && size > PAGE_SIZE);
> 
> Is this a busy-wait-until-someone-plugs-in-more-ram-chips thing? ;)

Well, with IBM hardware, you never know:-)

Yeah... that got fixed here in my 2.4 version, and I failed to transfer the
fix across. log2qty should be decremented every time around the loop:

-	} while (!table && size > PAGE_SIZE);
+	} while (!table && size > PAGE_SIZE && --log2qty);

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/