Re: ipw2100 wireless driver

[Vojtech Pavlik]

On Wed, Jul 14, 2004 at 04:07:52PM +0200, Andi Kleen wrote:

> Vojtech Pavlik <vojtech@xxxxxxx> writes:
> >
> > Wouldn't "struct sk_buff **fragments" be a more correct fix?
> 
> No, that would be a pointer to an array instead of the array itself.
> 
> Completely different thing.

Indeed.

> The best would be struct sk_buff *fragments[0]; 

Agreed. It's not a very nice construction anyway.

> [] here is C99, which 2.95 didn't even attempt to support.
> 
> -Andi
> 
> 
> >> --- ipw2100-ofic/ieee80211.h	2004-07-09 06:32:17.000000000 +0200
> >> +++ ipw2100-0.49/ieee80211.h	2004-07-14 13:18:50.000000000 +0200
> >> @@ -440,7 +440,7 @@
> >>  	u16 reserved;
> >>  	u16 frag_size;
> >>  	u16 payload_size;
> >> -	struct sk_buff *fragments[];
> >> +	struct sk_buff *fragments[1];
> 
> 

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/