Re: ext3: bump mount count on journal replay

[Andreas Dilger]

On Jul 14, 2004  15:15 +0200, Pavel Machek wrote:
> Currently, you get fsck "just to be sure" once every ~30 clean
> mounts or ~30 hard shutdowns. I believe that hard shutdown is way more
> likely to cause some disk corruption, so it would make sense to fsck
> more often when system is hit by hard shutdown.
> 
> What about this patch?
>
> @@ -1484,9 +1485,11 @@
>  	 * root first: it may be modified in the journal!
>  	 */
>  	if (!test_opt(sb, NOLOAD) &&
> -	    EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) {
> -		if (ext3_load_journal(sb, es))
> -			goto failed_mount2;
> +	    EXT3_HAS_COMPAT_FEATURE(sb, EXT3_FEATURE_COMPAT_HAS_JOURNAL)) { {
> +		    mount_cost = 5;
> +		    if (ext3_load_journal(sb, es))
> +			    goto failed_mount2;
> +	    }

AFAICS, this just means that if you have an ext3 filesystem
(i.e. has_journal) that you will fsck 5x as often, not so great.  You
should instead check for INCOMPAT_RECOVER instead of HAS_JOURNAL.

Instead, you could change this to only increment the mount count after
a clean unmount 20% of the time (randomly).  Since most people bitch
about the full fsck anyways this is probably the better choice than
increasing the frequency of checks and forcing the users to change the
check interval to get the old behaviour.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/             http://members.shaw.ca/golinux/

Attachment: pgp00000.pgp
Description: PGP signature