RE: [PATCH]2.6.7 MSI-X Update

[Nguyen, Tom L]

On Wednesday, July 14, 2004, Roland Dreier wrote:  
>Long, welcome back.  I will review your patch as soon as I have a
>little free time.
Thanks!

>I think it's OK to keep track of which MSI/MSI-X vectors have ISRs
>attached and which don't.  However I don't think free_irq() should
>return a vector to the free pool (that might be used by other
>devices).  In other words it should be OK for a correct driver to do
>
>	pci_enable_msix(pdev...);
>	request_irq(msix_vector1);
>	free_irq(msix_vector1);
>	request_irq(msix_vector1);
>	free_irq(msix_vector1);
>	pci_disable_msix(pdev...);
>
>(obviously with some code in between operations).
>
>I think we agree on this and I will read your code to find out what
>you actually do but I just wanted to make my proposed interface clear.
Yes. With the updated patch, free_irq() "only" keeps track of which 
MSI/MSI-X vectors having ISRs attached and which don't. It will not
return a vector to the free pool.

Thanks,
Long
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/