Re: [announce] HVCS for inclusion in 2.6 tree

[Paul Mackerras]

Ryan,

> I would like the attached HVCS driver considered for inclusion into the
> 2.6 mainline tree.  This is a ppc64 platform driver so I figured that
> maybe Paul MacKerras would like to sign off on the arch specific
> segments of this driver before inclusion.

The arch/ppc64 stuff mostly looks OK - however I would prefer that you
created a new arch/ppc64/kernel/hvcs.c (and include/asm-ppc64/hvcs.h)
rather than tripling the size of the existing hvconsole.c.  There are
a couple of whitespace nits (missing space after "if" in a couple of
places), and this:

> +#define HVCS_LONG_INVALID	0xFFFFFFFFFFFFFFFF

would look better as either ~0UL or -1L (and I don't see why it really
needs a #define).

Regards,
Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/