Re: [RFC][PATCH] More comment improvements for RCU primitives

[Paul Mckenney]

On Thu, Jul 22, 2004 at 11:25:20AM -0700, Stephen Hemminger wrote:
> On Mon, 19 Jul 2004 19:35:15 -0700
> Paul Mckenney <paulmck@xxxxxxxxxxxxxxx> wrote:
> 
> > Hello!
> > 
> > Here is a patch to improve the usefulness of the RCU primitives'
> > documentation.  Again, this probably interacts badly with existing
> > RCU patches, which I will fix when I incorporate feedback.
> > 
> > 						Thanx, Paul
> 
> If you are going to be this verbose (which is good), you may want to
> mention how this interacts on a UP system as well.

Good point...

My first thought would be to add a paragraph saying what happens
on a UP for call_rcu() and synchronize_kernel(), something like
for call_rcu():

	This primitive has the same effect on a UP system.
	For example, if an RCU read-side critical section
	is interrupted by a handler that invokes call_rcu(),
	the corresponding update function will be invoked
	some time after the RCU read-side critical section
	has completed, which will in turn be some time after
	the interrupt handler returns.

Does this seem reasonable?

						Thanx, Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/