Re: [PATCH] Fix NR_KEYS off-by-one error

From: Vojtech Pavlik
Date: Tue Jul 27 2004 - 12:58:26 EST


On Wed, Jul 28, 2004 at 01:37:00AM +0900, OGAWA Hirofumi wrote:

> Vojtech Pavlik <vojtech@xxxxxxx> writes:
>
> > > This all seems a bit inconclusive. Do we proceed with the original patch
> > > or not? If not, how do we fix the overflow which Hirofumi has identified?
> >
> > I think we should check the value in the ioctl, regardless of what's
> > NR_KEYS defined to.
>
> However, it breaks the current binary instead. (at least
> console-tools, kbdutils).

We can do both, then, if that helps.

--
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/