Re: [PATCH] Kconfig.debug: combine Kconfig debug options

[Randy.Dunlap]

On Tue, 27 Jul 2004 14:55:39 +0200 (MEST) Geert Uytterhoeven wrote:

| On Fri, 23 Jul 2004, Randy.Dunlap wrote:
| > . localizes the following symbols in lib/Kconfig.debug:
| >     DEBUG_KERNEL, MAGIC_SYSRQ, DEBUG_SLAB, DEBUG_SPINLOCK,
| >     DEBUG_SPINLOCK_SLEEP, DEBUG_HIGHMEM, DEBUG_BUGVERBOSE,
| >     DEBUG_INFO
| 
| Which architecture does _not_ use DEBUG_KERNEL or DEBUG_SLAB? The list is quite
| long... Aren't these generic?

Looks like all of them use DEBUG_KERNEL.

DEBUG_SLAB is not available in cris, h8300, m68knommu, sh, sh64,
or v850 AFAICT.  Yes/no ?


| Perhaps DEBUG_SPINLOCK can depend on just SMP only? Or do people want
| to debug spinlock code on machines that don't have SMP?

Yes, sounds good, I'll change that.
| 
| Perhaps DEBUG_HIGHMEM can depend on just HIGHMEM only?

Yes, will change that one also.

| (didn't check the whole list) Perhaps the first instance of DEBUG_INFO
| can depend on !SUPERH64 && !USERMODE only?

It could.  It depends on one's config (or code/patch) philosophy.
I was trying to be explicit about which arches support a config option
by including each arch in a list ("inclusion").  Or I could exclude
certain arches from config options ("exclusion").  The inclusion
method seems safer and more readable/maintainable to me, but that's
just one opinion.

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/