Re: [PATCH][2.6.8-rc1-mm1] decode local APIC errors

[Maciej W. Rozycki]

On Tue, 27 Jul 2004, Mikael Pettersson wrote:

> I got tired of having to manually decode local APIC
> error codes in problem reports sent to LKML, so I
> rewrote arch/i386/kernel/apic:smp_error_interrupt()
> to do the decoding for us. Instead of:
> 
> APIC error on CPU0: 04(00)
> 
> this patch makes the kernel print:
> 
> APIC error on CPU0: Send Accept Error (0x00)
> 
> The code handles multiple set error flags, and will
> also report if any unknown or reserved bits are set.

 Hmm, no objection in principle, but calling printk() for a string that
does not end with a trailing '\n' leads to log being messed up if another
message is placed from elsewhere inbetween.  Using sprintf() to construct
the message may be an unnecessary complication, though.  Perhaps it would
be reasonable to report a single bit per line.  What do you think?

 Anyway, please note that such decoding used to be there, but it was
removed in 2.4.0-test7 for being too verbose, IIRC. ;-)  For me either way
is alike, though.

  Maciej
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/