Re: [PATCH] Altix system controller communication driver

[Jes Sorensen]

>>>>> "Greg" == Greg Howard <ghoward@xxxxxxx> writes:

Greg> Hi Andrew, The following patch
Greg> ("altix-system-controller-driver.patch") implements a driver
Greg> that allows user applications to access the system controllers
Greg> on SGI Altix machines.  It applies on top of the 2.6.8-rc-mm1
Greg> patch.

Greg,

A few quick comments, there might be more, I just spotted these two
points quickly:

1) Please update the struct file_operations assignments to use
   .owner THIS_MODULE, etc. instead of owner:

2) Always check the return values from copy_from_user and copy_to_user
   to avoid userland feeing you bogus pointers.

Jes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/