Re: [PATCH] Altix system controller communication driver

From: Sam Ravnborg
Date: Wed Jul 28 2004 - 11:34:10 EST


On Wed, Jul 28, 2004 at 08:57:37AM -0700, Andrew Morton wrote:
> Greg Howard <ghoward@xxxxxxx> wrote:
> >
> > Hi Andrew,
> >
> > The following patch ("altix-system-controller-driver.patch")
> > implements a driver that allows user applications to access the system
> > controllers on SGI Altix machines. It applies on top of the
> > 2.6.8-rc-mm1 patch.

[Lost the original mail..]

I would also recommend running it through sparse.
http://sparse.bkbits.net
davej has a .tar.gz package somewhere at www.codemonkey.org.uk.

I did not see any particular issue, but noticed no __user annotations
around copy_{to,from}_user().

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/