Re: [PATCH] reduce swsusp casting

[Patrick Mochel]

On Wed, 28 Jul 2004, Dave Hansen wrote:

> I noticed that swsusp uses quite a few interesting casts for __pa() and
> cousins.  This patch moves some types around to eliminate some of those
> casts in the normal code.  The casts that it adds are around alloc's and
> frees, which is a much more usual place to see them.
>
> Pavel also noticed that there's a superfluous PAGE_ALIGN() right before
> a >>PAGE_SHIFT in pfn_is_nosave(), so that's been removed as well.

What are these patches against? I released a bunch of patches to swsusp
and pmdisk two weeks ago. I'm not sure if Andrew has picked them up yet.
It would be nice if you would patch against those.

> I haven't had a chance to do anything but test it, because that would
> involve me setting up a swsusp rig, which I'm more prone to screw up
> than the patch itself :)  I'd appreciate if anyone with a stable setup
> could make sure I didn't do anything too stupid.

I don't understand - have you really tested it or just compile-tested it?
If not, please do try it out for real. There is no reason to be scared of
swsusp, and the more people that use it, the more stable it will get.

Thanks,


	Pat
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/