Re: [PATCH] Improve pci_alloc_consistent wrapper on preemptivekernels

[Andrew Morton]

Andi Kleen <ak@xxxxxxx> wrote:
>
> This is a minor optimization for the pci_alloc_consistent wrapper for
>  the generic dma API. When the kernel is compiled preemptive the caller
>  can decide if the allocation needs to be GFP_KERNEL or GFP_ATOMIC.

We're paying for past sins here.  I think it would be better to create a
new version of pci_alloc_consistent() which takes gfp_flags, then migrate
the drivers you care about to use it.  That way the benefit is available on
non-preempt kernels too.

The ultimate aim of course would be to deprecate then remove the old
function.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/