Re: PATCH: VLAN support for 3c59x/3c90x

[Willy Tarreau]

On Sat, Jul 31, 2004 at 07:35:45PM +1000, Herbert Xu wrote:
> On Sat, Jul 31, 2004 at 10:33:08AM +0200, Willy Tarreau wrote:
> > 
> > So several reasons :
> >   - the change_mtu() function might be called at any time after driver
> >     initialization. I don't know at all if there are things to do to
> 
> See the sungem.c for a working implementation.

Indeed, I remember having read parts of it several times because it was
very clean. I agree that the first half of the function does the same
thing as the initialization code. What is more of a problem is the second
half which resets the card, because inserting resets in the tulip driver
is not trivial (at least to me). But perhaps it would be acceptable to
only implement the dev->mtu change when the device is not up.

> BTW I presume this is for the tulip driver? Does it actually use the
> mtu parameter for anything? It seems to just store it in dev->mtu and
> then promptly forgets about it.

It's for the tulip driver. Now, you're right, it doesn't use dev->mtu at
all (just noticed now) ! So this is fairly simpler, since I then assume
that the driver will work up to PKT_BUF_SZ - 14 or 18.

Ok, I have the hardware, you've convinced me. I'll try it.

Cheers,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/