Re: [PATCH] Fix kallsyms dependency

[Sam Ravnborg]

On Sun, Aug 08, 2004 at 12:32:30PM +0100, Russell King wrote:
> Hi,
> 
> It appears that kallsyms data is not updated if the kallsyms program is
> changed.  The following patch adds an appropriate dependency.

Added, and implemented your suggestion in scripts/Makefile
with a few other CONFIG selections.

Btw. any specific reason to hack kallsyms? Just curious if something
shows up in this area.

Patch added for reference.

	Sam
	
===== Makefile 1.510 vs edited =====
--- 1.510/Makefile	2004-08-07 21:35:27 +02:00
+++ edited/Makefile	2004-08-08 17:26:49 +02:00
@@ -584,7 +584,7 @@
 .tmp_kallsyms1.o .tmp_kallsyms2.o .tmp_kallsyms3.o: %.o: %.S scripts FORCE
 	$(call if_changed_dep,as_o_S)
 
-.tmp_kallsyms%.S: .tmp_vmlinux%
+.tmp_kallsyms%.S: .tmp_vmlinux% $(KALLSYMS)
 	$(call cmd,kallsyms)
 
 .tmp_vmlinux1: $(vmlinux-objs) arch/$(ARCH)/kernel/vmlinux.lds.s FORCE
===== scripts/Makefile 1.40 vs edited =====
--- 1.40/scripts/Makefile	2004-07-23 01:27:54 +02:00
+++ edited/scripts/Makefile	2004-08-08 17:31:59 +02:00
@@ -5,11 +5,14 @@
 # docproc: 	 Preprocess .tmpl file in order to generate .sgml docs
 # conmakehash:	 Create arrays for initializing the kernel console tables
 
-host-progs	:= conmakehash kallsyms pnmtologo bin2c
+host-progs-$(CONFIG_KALLSYMS) += kallsyms
+host-progs-$(CONFIG_LOGO)     += pnmtologo
+
+host-progs	:= $(host-progs-y) conmakehash bin2c
 always		:= $(host-progs)
 
-subdir-$(CONFIG_MODVERSIONS)	+= genksyms
-subdir-y	+= mod
+subdir-$(CONFIG_MODVERSIONS) += genksyms
+subdir-$(CONFIG_MODULES)     += mod
 
 # Let clean descend into subdirs
 subdir-	+= basic lxdialog kconfig package
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/