Re: [PATCH] Reduce bkl usage in do_coredump

[Josh Aas]

> Might be nicer to just put the locking inside of format_corename() if it
> is the function itself that really needs the locking.  If another use of
> it popped up, that user would get the locking for free and couldn't
> possibly forget it.  Also, it's nicer to put the lock closer to the code
> that actually needs it.  Untested patch to do that attached.

Probably a good idea.

> BTW, were you actually seeing a BKL contention problem, or was this just
> for cleanliness?

We have actually seen contention in do_coredump.

--
Josh Aas
Silicon Graphics, Inc. (SGI)
Linux System Software
651-683-3068
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/