Re: Linux Kernel bug report (includes fix)

[Joerg Schilling]

>From: Jim Gifford <maillist@xxxxxxxxx>


>There is a simple fix to your problem, I have sent this patch to you a 
>few times, but never got an answer.

>I bet eveyone here will agree, this is the proper way to fix the issue

Of course, what you like to do is not the proper way....

>-DEFINCDIRS=    $(SRCROOT)/include /usr/src/linux/include
>+DEFINCDIRS=    $(SRCROOT)/include

/usr/src/linux/include is definitely needed on Linux-2.2 and before



> #if LINUX_VERSION_CODE >= 0x01031a /* <linux/scsi.h> introduced in 
>1.3.26 */
> #if LINUX_VERSION_CODE >= 0x020000 /* <scsi/scsi.h> introduced 
>somewhere. */
>+
>+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 0)
>+    #define __KERNEL__
>+    #include <asm/types.h>
>+    #include <asm/byteorder.h>
>+    #undef __KERNEL__
>+#endif

If an application would need to #define __KERNEL__ and to include 
inofficial include files, the official include files are broken 
and should be fixed. This is exactly the reason why I send a bug report
against include/scsi/scsi.h & include/scsi/sg.h



Jörg

-- 
 EMail:joerg@xxxxxxxxxxxxxxxxxxxxxxxxxxx (home) Jörg Schilling D-13353 Berlin
       js@xxxxxxxxxxxxxxx		(uni)  If you don't have iso-8859-1
       schilling@xxxxxxxxxxxxxxxxxxx	(work) chars I am J"org Schilling
 URL:  http://www.fokus.fraunhofer.de/usr/schilling ftp://ftp.berlios.de/pub/schily
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/