Re: [1/4] Exceptions Notifier patch

[Andi Kleen]

Prasanna S Panchamukhi <prasanna@xxxxxxxxxx> writes:

Just some cosmetical comments.

>  
> +EXPORT_SYMBOL(register_die_chain_notify);

Please name it "register_die_notifier" 

>  
>  static int kstack_depth_to_print = 24;
> +struct notifier_block *i386die_chain;
> +static DECLARE_MUTEX(i386die_chain_mutex);

s/i386//

I don't know why you made this a mutex, a spinlock would 
be fine too. But that's a minor issue.

Rest looks ok.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/