Re: [2.6 patch] net/seeq8005.c: small cleanups (fwd)

[Jeff Garzik]

Adrian Bunk wrote:
> The trivial patch forwarded below still applies and compiles against 
> 2.6.8-rc3-mm2.
>
> Please apply.
>
>
> ----- Forwarded message from Adrian Bunk <bunk@xxxxxxxxx> -----
>
> Date:	Fri, 16 Jul 2004 00:17:42 +0200
> From: Adrian Bunk <bunk@xxxxxxxxx>
> To: hamish@xxxxxxxxxxxxxxxx
> Cc: jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx,
> 	linux-kernel@xxxxxxxxxxxxxxx
> Subject: [2.6 patch] net/seeq8005.c: small cleanups
>
> The patch below does the following small cleanups in seeq8005.c:
> - kill ancient version variable
> - remove Emacs settings
>
>
> diffstat output:
>  drivers/net/seeq8005.c |   18 ------------------
>  1 files changed, 18 deletions(-)
>
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>
> --- linux-2.6.8-rc1-mm1-full-3.4/drivers/net/seeq8005.c.old	2004-07-16 00:08:55.000000000 +0200
> +++ linux-2.6.8-rc1-mm1-full-3.4/drivers/net/seeq8005.c	2004-07-16 00:09:28.000000000 +0200
> @@ -12,12 +12,7 @@
>  	This file is a network device driver for the SEEQ 8005 chipset and
>  	the Linux operating system.
>  
> -*/
> -
> -static const char version[] =
> -	"seeq8005.c:v1.00 8/07/95 Hamish Coleman (hamish@xxxxxxxxxxxxxxxx)\n";
>  
> -/*
>    Sources:
>    	SEEQ 8005 databook
>    	
> @@ -150,7 +145,6 @@
>  
>  static int __init seeq8005_probe1(struct net_device *dev, int ioaddr)
>  {
> -	static unsigned version_printed;
>  	int i,j;
>  	unsigned char SA_prom[32];
>  	int old_cfg1;
> @@ -291,9 +285,6 @@
>  	}
>  #endif
>  
> -	if (net_debug  &&  version_printed++ == 0)
> -		printk(version);
> -


This "small cleanup" appears to kill useful and working code.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/