Re: [patch] fix netconsole hang with alt-sysrq-t

[Muli Ben-Yehuda]

On Thu, Aug 12, 2004 at 05:32:21PM -0400, Jeff Moyer wrote:
> ==> Regarding Re: [patch] fix netconsole hang with alt-sysrq-t; Muli Ben-Yehuda <mulix@xxxxxxxxx> adds:
> 
> mulix> On Thu, Aug 12, 2004 at 05:01:18PM -0400, Jeff Moyer wrote:
> >> So how do you want to deal with this case?  We could do something like:
> >> 
> >> int cpu = smp_processor_id();
> 
> mulix> That doesn't look right, unless I'm missing something, you could get
> mulix> preempted here (between the smp_processor_id() and the
> mulix> local_irq_save() and end up with 'cpu' pointing to the wrong CPU.
> 
> Would a preempt_disable() be too hideous?  Other suggestions?

Maybe, but we could hide it in get_cpu() / put_cpu() ;-)

Cheers, 
Muli
-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

Attachment: signature.asc
Description: Digital signature