Re: [2.6 patch] let W1 select NET

[Cornelia Huck]

On Fri, 13 Aug 2004 12:54:12 +0200
Adrian Bunk <bunk@xxxxxxxxx> wrote:

> It's also relatively safe since NET itself doesn't has any
> dependencies.

Otherwise, this would be problematic. Consider the following:

config FOO
        bool "foo"
        select BAR

config BAR
        bool
        depends on BAZ

config BAZ
        bool
        default n

You can select FOO, which will select BAR. In your config, you'll end up with
CONFIG_FOO=y
CONFIG_BAR=y
# CONFIG_BAZ is not set

(similar result if you don't specify BAZ at all), which would get you into trouble. (I saw this while looking into what happens if s390 uses drivers/Kconfig, and got a headache why some stuff was selected by
allyesconfig that depended on pci).

Question: Is this a bug or a feature? If the latter, select should probably not be used on anything that has dependencies...

Regards,
Cornelia
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/