Re: [PATCH][linux-usb-devel] Early USB handoff

[Pete Zaitcev]

On Mon, 16 Aug 2004 13:06:17 -0700
"Aleksey Gorelov" <Aleksey_Gorelov@xxxxxxxxxxx> wrote:

>   Here is slightly improved early USB legacy handoff patch for 2.4.27

The usual caveat is how we all wait for this to go into 2.6.

>   I've tested it on a number of machines (mostly laptops) for UHCI &
> OHCI, but PC with EHCI BIOS legacy support was hard to find. I tried
> Intel D865GRH, but seems like BIOS there have some problems (like lock
> up during POST when flash drive plugged in), and does not adhere EHCI
> handoff protocol.

That part looked ok. Such computers are semi-popular. Our QA department
has Thinkpads with similarly broken BIOS. I'm glad you did not decide
to call panic() in such case :-)

>   Handoff is under no-usb-legacy option.
> +int disable_legacy_usb __initdata = 0;

I think it's an unfortunate naming. When I was reading the patch, I got
the meaning exactly backwards. I think that we should not be afraid
of using something like "do handoff" or "do NOT do a handoff" in the
documentation and flag names, for extra clarity.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/