Re: [PATCH] notify_parent cleanup

[OGAWA Hirofumi]

Roland McGrath <roland@xxxxxxxxxx> writes:

> > Roland McGrath <roland@xxxxxxxxxx> writes:
> > > +	BUG_ON(tsk->state != TASK_STOPPED);
> > 
> > task->state is changed anytime, right?  Although the window is small,
> > I think we should remove it at least for right now.

> I put it there intending just to ensure that all the code paths
> were the stopping ones, as all the extant ones are.

Ah, I see.

Instead of BUG_ON(), how about WARN_ON() for debug? Since window is
small...
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/