Re: module.viomap support for ppc64

[Rusty Russell]

On Fri, 2004-08-20 at 07:28, Olaf Hering wrote:
>  On Fri, Aug 13, Rusty Russell wrote:
> 
> > On Fri, 2004-08-13 at 19:40, Olaf Hering wrote:
> > >  On Fri, Aug 13, Rusty Russell wrote:
> > > 
> > > > 2) Please modify scripts/mod/file2alias.c in the kernel source, not the
> > > > module tools.  The modules.XXXmap files are deprecated: device tables
> > > > are supposed to be converted to aliases in the build process, and that
> > > > is how userspace tools like hotplug are to find them.
> > > 
> > > I found no user of the modules.alias file. Hotplug still uses the map
> > > files. Parsing one big file will not improve performance, but thats a
> > > different story.
> > 
> > You don't use the modules.alias file.  You simply "modprobe vio:xyz^abc"
> > and modprobe reads modules.alias if necessary (the user can also insert
> > aliases in the modprobe.conf file, for example).  Note that fnmatch is
> > used, so you can actually use ? and * in your generated aliases.
> 
> But that complicates the parser. Current the hotplug agent script reads
> the simple modules.foomap and generates a list of possible drivers. Then
> it looks into the blacklist file to see if one of the possible modules
> should not be loaded, and skips this module.

Complicates?   Leave it to modprobe.  Don't read any files.  Really.

Current implementation of aliases is to load one at random: multiple
alias resolution is undefined because noone knew what we should do (load
them all?  Load until one succeeds?).  But note that that the base
config file overrides anything extracted from the modules themselves, so
users/distributions can always specify an exact match.

> Is there such functionality for the modules.alias file in
> module-init-tools? I played around with modprobe -n, but could not
> figure it out. Unfortunately, some hardware has more than one driver.
> bcm5700/tg3, eepro100/e100 and maybe more.

OK, I think the difference here is that I feel modprobe should resolve
it.  What's the right answer?  Do we need a new "unalias" config cmd
which does the blacklist, or is the current positive method better?  How
do you currently decide?

Thanks!
Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/