Re: [PATCH] Writeback page range hint

[Andrew Morton]

Dave Jones <davej@xxxxxxxxxx> wrote:
>
> FYI, this chunk...
> 
>   >  	long pages_skipped;		/* Pages which were not written */
>   > -	int nonblocking;		/* Don't get stuck on request queues */
>   > -	int encountered_congestion;	/* An output: a queue is full */
>   > -	int for_kupdate;		/* A kupdate writeback */
>   > -	int for_reclaim;		/* Invoked from the page allocator */
>   > +
>   > +	/*
>   > +	 * For a_ops->writepages(): is start or end are non-zero then this is
>   > +	 * a hint that the filesystem need only write out the pages inside that
>   > +	 * byterange.  The byte at `end' is included in the writeout request.
>   > +	 */
>   > +	loff_t start;
>   > +	loff_t end;
>   > +
>   > +	int nonblocking:1;		/* Don't get stuck on request queues */
>   > +	int encountered_congestion:1;	/* An output: a queue is full */
>   > +	int for_kupdate:1;		/* A kupdate writeback */
>   > +	int for_reclaim:1;		/* Invoked from the page allocator */
> 
>  Causes sparse spew..
> 
>  include/linux/writeback.h:54:19: warning: dubious one-bit signed bitfield
>  include/linux/writeback.h:55:30: warning: dubious one-bit signed bitfield
>  include/linux/writeback.h:56:19: warning: dubious one-bit signed bitfield
>  include/linux/writeback.h:57:19: warning: dubious one-bit signed bitfield

That's fussy of it.  I assume this shuts it up?

--- 25/include/linux/writeback.h~writeback-sparse-warning-fix	2004-08-23 18:12:09.669385176 -0700
+++ 25-akpm/include/linux/writeback.h	2004-08-23 18:12:44.064156376 -0700
@@ -51,10 +51,10 @@ struct writeback_control {
 	loff_t start;
 	loff_t end;
 
-	int nonblocking:1;		/* Don't get stuck on request queues */
-	int encountered_congestion:1;	/* An output: a queue is full */
-	int for_kupdate:1;		/* A kupdate writeback */
-	int for_reclaim:1;		/* Invoked from the page allocator */
+	unsigned int nonblocking:1;	/* Don't get stuck on request queues */
+	unsigned int encountered_congestion:1;	/* An output: a queue is full */
+	unsigned int for_kupdate:1;	/* A kupdate writeback */
+	unsigned int for_reclaim:1;	/* Invoked from the page allocator */
 };
 
 /*
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/