Re: [PATCH] unexport get_wchan

[Andreas Dilger]

On Sep 07, 2004  20:49 +0200, Christoph Hellwig wrote:
> Well, you kdb cotains quite a few other patches to core code already,
> no?  And it could add back a single EXPORT_SYMBOL in a common place
> instead of duplicated over every architecture..

I think most projects' goals is to reduce the number of patches they need
to make to the kernel instead of increasing them...  If you think it is
ugly to have multiple EXPORT_SYMBOLS() then it should just be moved to
the line after the function definition.  Having to add another configure
rule to check for now-unexported symbols isn't my idea of time well spent
(not that I care about this one in particular).

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://members.shaw.ca/adilger/             http://members.shaw.ca/golinux/

Attachment: pgp00000.pgp
Description: PGP signature