Re: [PATCH-NEW] allow root to modify raw scsi command permissionslist

[Marc Ballarin]

On Wed, 15 Sep 2004 22:38:47 +0100
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> You need to check for capable(CAP_SYS_RAWIO) otherwise you elevate
> anyone with access bypass capabilities to CAP_SYS_RAWIO equivalent
> powers.

True. File permissions aren't enough.

Will something like this suffice?

static ssize_t rcf_store_write(struct rawio_cmd_filter *rcf, const char *page,
			size_t count)
{

	...	
	
	if (!capable(CAP_SYS_RAWIO))
		return -EPERM;
	
	while(i < RCF_MAX_NR_CMDS)
		clear_bit(i++, rcf->write_ok);
	...

Regards
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/