Re: [PATCH] APIC physical broadcast for i82489DX

[William Lee Irwin III]

On Thu, Oct 07, 2004 at 03:24:23PM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2133, 2004/10/07 08:24:23-07:00, macro@xxxxxxxxxxxxxx
> 	[PATCH] APIC physical broadcast for i82489DX
> 	The physical broadcast ID is determined incorrectly for the i82489DX,
> 	which uses 8-bit physical addressing (32-bit logical).
>  apic.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> diff -Nru a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c
> --- a/arch/i386/kernel/apic.c	2004-10-07 09:10:03 -07:00
> +++ b/arch/i386/kernel/apic.c	2004-10-07 09:10:03 -07:00
> @@ -91,7 +91,7 @@
>  	unsigned int lvr, version;
>  	lvr = apic_read(APIC_LVR);
>  	version = GET_APIC_VERSION(lvr);
> -	if (version >= 0x14)
> +	if (!APIC_INTEGRATED(version) || version >= 0x14)
>  		return 0xff;
>  	else
>  		return 0xf;

This is the same as version <= 0xf || version >= 0x14; I'm rather
suspicious, as the docs have long since been purged, making this
hopeless for anyone without archives (or a good memory) dating back to
that time to check. All that's really needed is citing the version that
comes out of the version register and checking other APIC
implementations to verify they don't have versions tripping this check,
the latter of which is feasible for those relying on still-extant
documentation. Better yet would be dredging up the docs... So, what is
the range of the version numbers reported by i82489DX's?


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/