Re: [PATCH] QStor SATA/RAID driver for 2.6.9-rc3

[James Bottomley]

On Fri, 2004-10-08 at 10:34, Mark Lord wrote:
> If those locks are not needed, the scsi.c maintainer really should
> nuke'em.

I think you can safely assume he has more important things to do.

> > Really, I suppose, libata should provide the interfaces for doing this
> > work for emulated commands.
> 
> Well, after this driver submission work is done with,
> that's next on my list.  Right now libata doesn't have
> the right interface for easy sharing of such functions.

Not emulating an INQUIRY properly via SG_IO isn't acceptable since it's
a mandatory command.

libata does all this correctly.  I strongly suggest you find a way to
share the code rather than trying to reinvent it yourself.  But anyway,
if you want to know how it should work, look in libata-scsi.c

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/