Re: [PATCH] amd8111e endian & barrier fixes

[Benjamin Herrenschmidt]

On Fri, 2004-10-08 at 21:47, Andi Kleen wrote:

> It's basically impossible to review the patch properly because
> of that change. Can you please separate the arbitary white space
> change into a different patch? 

Hrm... I think you are doing too much here ;) The change concerns only a
single function and is still quite readable :) But anyways, I'll
eventually do that next week.

> Also I would suggest you send the patch to the driver 
> maintainers for review first (cc'ed) 

Well, I would have done if any maintainer email was in the source code,
which isn't the case, but thanks for providing them :)

> >From a quick look the change to clear the ring rx flags completely
> instead of clearing the bit looks bogus. Why did you not just add a
> endian conversion there?

Because the bits mask was ... 0 :)

> I can test it when it's properly reviewd.

Sure. No hurry.

Ben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/