Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h

From: viro
Date: Mon Oct 11 2004 - 09:08:54 EST


On Mon, Oct 11, 2004 at 09:12:03AM -0400, Pavel Roskin wrote:
> Another, more sophisticated solution would be to use union for iobase:
>
> typedef struct hermes {
> union {
> unsigned long io;
> void *mem;
> } base;
> int io_space; /* 1 if we IO-mapped IO, 0 for memory-mapped IO? */
> ...
> }

Not needed. Use ioread*/iowrite* family; it does what you need.

Al, putting together a patchset and documention on that sort of cleanups...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/